check recv size by bjnhur · Pull Request #34 · adafruit/Adafruit_CircuitPython_Wiznet5k

bjnhur · 2021-04-11T08:19:52Z

I saw the message from your example as follows.

Opening W5k Socket, protocol=33
socket connected
Socket read 0
socket_available called with protocol 33
b''
PHY Status: bytearray(b'\xbf')
*** Disconnecting socket #0
*** Closing socket #0

connect -> zero byte recv -> disconnect.
So, I can't test ECHO data.
How about adding check code that recv size is not zero?

adafruit_wiznet5k/adafruit_wiznet5k.py

gamblor21 · 2021-04-11T14:50:27Z

Looked the code over but could not test it as I don't have the hardware.

Co-authored-by: Mark <56205165+gamblor21@users.noreply.github.com>

adafruit_wiznet5k/adafruit_wiznet5k_dhcp.py

examples/wiznet5k_simpleserver.py

adafruit_wiznet5k/adafruit_wiznet5k.py

examples/wiznet5k_simpleserver.py

brentru · 2021-04-16T13:51:12Z

@bjnhur The most recent commit is failing on Black formatting: (https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k/pull/34/checks?check_run_id=2350143393#step:11:30).

Please read thru https://learn.adafruit.com/improve-your-code-with-pylint and make the required changes for this PR to pass, thank you. Feel free to ask me any questions you have.

brentru · 2021-05-06T13:23:05Z

@bjnhur Could you resolve the conflicts, then I'll test? Thanks

…Python_Wiznet5k

jposada202020 · 2021-05-26T11:29:17Z

@brentru Hello, I think this PR is ready to review, could you take a look to see if this is ok? thanks.

brentru · 2021-05-26T21:55:51Z

@jposada202020 I'll test this tomorrow, added to my TODOs.

Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x#23 from jposada202020/improving_docs > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x#22 from caternuson/iss21 Updating https://github.com/adafruit/Adafruit_CircuitPython_DPS310 to 1.2.6 from 1.2.5: > Merge pull request adafruit/Adafruit_CircuitPython_DPS310#17 from jposada202020/correcting_returning_units > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.10 from 3.5.9: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#132 from mikejc58/wait_spi_char > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.3.7 from 3.3.6: > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#36 from jvalrog/fix-servo-example > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_SI5351 to 1.2.8 from 1.2.7: > Merge pull request adafruit/Adafruit_CircuitPython_SI5351#21 from jposada202020/changing_assertions > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA9548A to 0.5.0 from 0.4.0: > Merge pull request adafruit/Adafruit_CircuitPython_TCA9548A#35 from jposada202020/adding_example_docs_improvement > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.10.1 from 1.10.0: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#34 from bjnhur/master > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.5.1 from 1.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#47 from adafruit/linting > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.9.3 from 1.9.2: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#39 from adafruit/linting > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#37 from jposada202020/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Gizmo to 1.3.2 from 1.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_Gizmo#18 from adafruit/linting > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 5.0.1 from 5.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_HID#69 from jfurcean/fix-led-example > Merge pull request adafruit/Adafruit_CircuitPython_HID#70 from FoamyGuy/adding_brightness_codes > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_ProgressBar to 2.2.0 from 2.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_ProgressBar#31 from jposada202020/progressbar_accelerometer > Merge pull request adafruit/Adafruit_CircuitPython_ProgressBar#30 from alimustafashah/master > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.8.4 from 1.8.3: > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#69 from jfurcean/add-rotaryio-docs Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.11.5 from 2.11.4: > Empty commit - related to main switch > Moved default branch to main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.10.2 from 1.10.1: > Moved default branch to main < Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#34 from bjnhur/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Dash_Dis to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_Dash_Dis#1 from jposada202020/improving_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_FunHouse to 2.1.3 from 2.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#16 from caternuson/slider Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_Simple_Text_Display

Recreating #34

Bongjun Hur added 2 commits April 11, 2021 17:15

check recv size

33496d1

before DHCP, check link status first

ec91aff

gamblor21 reviewed Apr 11, 2021

View reviewed changes

adafruit_wiznet5k/adafruit_wiznet5k.py Outdated Show resolved Hide resolved

adafruit_wiznet5k/adafruit_wiznet5k.py Outdated Show resolved Hide resolved

Bongjun Hur and others added 3 commits April 12, 2021 13:15

Update adafruit_wiznet5k/adafruit_wiznet5k.py

8179adc

Co-authored-by: Mark <56205165+gamblor21@users.noreply.github.com>

add 5seconds timeout during link check

6473abe

before sending, _BUFF buf clear in DHCP

c91daed

brentru requested changes Apr 12, 2021

View reviewed changes

init _BUFF - one line code

cde9d66

bjnhur requested a review from brentru April 14, 2021 06:38

brentru requested changes Apr 14, 2021

View reviewed changes

examples/wiznet5k_simpleserver.py Outdated Show resolved Hide resolved

examples/wiznet5k_simpleserver.py Outdated Show resolved Hide resolved

link check in set_dhcp

456fc8a

Bongjun Hur added 2 commits April 17, 2021 14:56

move out accept() from while, specify 1024 byte

93399f6

crlf -> lf

baca531

bjnhur requested a review from brentru April 21, 2021 23:49

Merge branch 'master' of https://github.com/adafruit/Adafruit_Circuit…

9dedc5c

…Python_Wiznet5k

brentru approved these changes May 27, 2021

View reviewed changes

brentru merged commit 847070e into adafruit:master May 27, 2021

evaherrada added a commit that referenced this pull request Jun 7, 2021

Merge pull request #38 from bjnhur/master

d50fe38

Recreating #34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

check recv size#34

check recv size#34
brentru merged 10 commits intoadafruit:masterfrom
bjnhur:master

bjnhur commented Apr 11, 2021

Uh oh!

Uh oh!

Uh oh!

gamblor21 commented Apr 11, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brentru commented Apr 16, 2021

Uh oh!

brentru commented May 6, 2021

Uh oh!

jposada202020 commented May 26, 2021

Uh oh!

brentru commented May 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

bjnhur commented Apr 11, 2021

I saw the message from your example as follows.

Uh oh!

Uh oh!

Uh oh!

gamblor21 commented Apr 11, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brentru commented Apr 16, 2021

Uh oh!

brentru commented May 6, 2021

Uh oh!

jposada202020 commented May 26, 2021

Uh oh!

brentru commented May 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants